commit e8e56a0768f85183e7ad43a96e7cd1b78267dbe0
author Aditya Thakral <9at8@users.noreply.github.com> Wed Jul 15 21:05:28 2020 +0000
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Wed Jul 15 21:52:22 2020 +0000
tree 3f49d63f5fee4495533fc341b26ef7b12f0a9787
parent b52aa5ba6c70eb4765a0be675fad3b1b84f74b86

package.json: make `additionalProperties` false for object type settings

When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `additionalProperties` to `false` for the objects that don't expect more properties would be great!

As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if `additionalProperties` is `false` and all known properties are present.

Change-Id: I92380610b24f7cd6ee790f2e020b9c689c3ff25b
GitHub-Last-Rev: 695aa78bbd7bdf09f06d3ab84392510471862a73
GitHub-Pull-Request: golang/vscode-go#284
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240907
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

package.json

diff --git a/package.json b/package.json
index 8d9c767..f69a597 100644
--- a/package.json
+++ b/package.json
@@ -1380,6 +1380,7 @@
               "description": "Gutter style to indicate covered code."
             }
           },
+          "additionalProperties": false,
           "default": {
             "type": "highlight",
             "coveredHighlightColor": "rgba(64,128,128,0.5)",
@@ -1518,6 +1519,7 @@
               "description": "If true, the language server will provide clickable Godoc links for import statements."
             }
           },
+          "additionalProperties": false,
           "default": {
             "diagnostics": true,
             "documentLink": true
@@ -1565,6 +1567,7 @@
               "description": "If true, enables code lens for running and debugging tests"
             }
           },
+          "additionalProperties": false,
           "default": {
             "references": false,
             "runtest": true
@@ -1600,6 +1603,7 @@
               "description": "Transformation rule used by Go: Add Tags command to add tags"
             }
           },
+          "additionalProperties": false,
           "default": {
             "tags": "json",
             "options": "json=omitempty",
@@ -1623,6 +1627,7 @@
               "description": "The number of milliseconds to delay before execution. Resets with each keystroke."
             }
           },
+          "additionalProperties": false,
           "default": {
             "enabled": false,
             "delay": 500
@@ -1649,6 +1654,7 @@
               "description": "Comma separated tag=options pairs to be used by Go: Remove Tags command"
             }
           },
+          "additionalProperties": false,
           "default": {
             "tags": "",
             "options": "",
@@ -1677,6 +1683,7 @@
             },
             "description": "The flags configured here will be passed through to command `goplay`"
           },
+          "additionalProperties": false,
           "default": {
             "openbrowser": true,
             "share": true,
@@ -1757,6 +1764,7 @@
               "description": "If true, adds command to debug the test under the cursor to the editor context menu"
             }
           },
+          "additionalProperties": false,
           "default": {
             "toggleTestFile": true,
             "addTags": true,
@@ -1890,7 +1898,8 @@
               "default": "guru",
               "description": "Alternate tool to use instead of the guru binary or alternate path to use for the guru binary."
             }
-          }
+          },
+          "additionalProperties": false
         }
       }
     },