tree 002bd80067fad82a83b1428cc7245aa5a196e1ef
parent f05c05e9234f5e6c4cfef6d41a8f2b7b3530d382
author Hana <hyangah@gmail.com> 1605275384 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1605293699 +0000

src/goTest: always mark workspace uri as directory

This completes the bug https://go-review.googlesource.com/c/vscode-go/+/242642
intended to fix  - isModSupported treats the first parameter as a directory
only if the second parameter is set. I don't know why I thought we shouldn't
set when there is active text editer. workspace file path should be always
a directory.

This bug made the `testWorkspace` function (in goTest.ts) to incorrectly
populate testConfig's isMod field. That caused the `goTest` function failed to
compute the pkgMap correctly when the workspace has go.mod. (See line 308-321
of testUtils.ts).

Without pkgMap, `processTestResultLineInStandardMode` couldn't compute
the path-to-directory path mapping. As a result,
  - the file name expansion (expandFIlePathInOutput) couldn't work, and
  - the test output was buffered until all tests in the workspace
    finished. (golang/vscode-go#917)

While we are here, this CL updates the test output match regexp
to capture the line like `? pkgpath [no test files]`, and fixes two lint errors
reported by eslint (goModules.ts)

Fixes golang/vscode-go#917

Change-Id: Ib3c9e66a1295a0673c8fed1b45399c4d156cd3b0
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/269917
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Peter Weinberger <pjw@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>