tree 7ac02cbd7b399c8a4557237ec2da7c156cf4a1e5
parent d767aa07397e94c220cc4f70f29290d95785f314
author Hana <hyangah@gmail.com> 1618589784 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1618881453 +0000

[release] src/goInstallTools: use GOBIN correctly installing dlv-dap/gocode-gomod

We incorrectly added `bin` to the final binary path
when the destination was determined by GOBIN env var.

Changed install.test.ts to set the temporary GOPATH instead of
stubbing getToolsGopath. When populating tools installation
environment, the extension ignores GOBIN if users configured
go.toolsGopath currently, so depending on toolsGopath to point
to the temporary GOPATH prevents from testing GOBIN-related
behavior.

Fixes golang/vscode-go#1430

Change-Id: Id6450e9422a791f6d5e7810f6bbbec1bc695e924
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/310769
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
(cherry picked from commit 015d002ce9a45045bd4eba451094bedb7fe732d1)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/311450
Reviewed-by: Suzy Mueller <suzmue@golang.org>