tree 58e89e9b23d4a4d07d73da75277c844b7979461e
parent a42b5de115d2a05cea249bbbb68525747d34ea84
author Hana <hyangah@gmail.com> 1601477747 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1601490470 +0000

[release] src/goInstallTools.ts: add GOROOT/bin to PATH when it wasn't found from PATH

The fix for golang/vscode-go#679 changed to prepend GOROOT/bin to PATH or Path
only if users explicitly configured to use go different from what's found from PATH.
I forgot the case where go was not found from PATH and the extension picked up
a common default go installation directory. (C:\Go\bin or /usr/local/go/bin).

This change rewrote the fix - rewrote getBinPath to return why it chose the
path as well. Then, we mutate the PATH env var if getBinPath picked
go with a reason other than it's in PATH (why === 'path').

Since getBinPath and getBinPathWithPreferredGopathGoroot are
used in many places, this CL introduces getBinPathWithExplanation and
getBinPath wraps it.

Updates golang/vscode-go#679
Fixes golang/vscode-go#713

Change-Id: Ie00612fcef2cf4c2a187a263da04b342182c030b
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/258316
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
(cherry picked from commit 9bf9d642c76369144bc85323622240a121868454)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/258519