tree 7da450f9dc117c6c5dde7354aba430566af2357d
parent fe7b40b1b2947b916be5f9c3bb68ca3abf76d6b7
author Hana <hyangah@gmail.com> 1621488511 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1621546551 +0000

src/goDebugFactory: respond with error if dlv dap failed to start

DelveDAPOutputAdapter constructor begins spawning of dlv dap
process but it doesn't wait until the dlv dap process is up and
running. The success or failure of dlv dap process launch is
lazily detected when the client sends messages. Previously,
we just sent a TerminatedEvent and pop up an error notification.
This CL changes DelveDAPOutputAdapter to respond with
DebugProtocol.ErrorResponse, so the client can handle the error
 - displaying the error with a modal popup
 - changing focus so DEBUG CONSOLE becomes visible

And made startAndConnectToServer catches errors and never
throw an error (reject the promise). So, DelveDAPOutputAdapter's
'connected' will never be rejected and explicitly store the error
message. Previously this rejected promise caused warnings, i.e.,
rejected promise not handled within X seconds.

Did some clean up of unnecessary async or declaration.
And, fixed and reenabled logDest tests.

Change-Id: I57b7d52d83a82c506629e07b1dec65f9e02801bc
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/321472
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>