tree 5fa4f713c0482146698b4583524afbaa01a1f53a
parent fae8cb91326001be92dc59d5b685372be554f8d3
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> 1701710766 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1701995175 +0000

src/goTest: fix bugs in subtest handling

This change addresses two issues

1. When the subtest name includes regexp metacharacters,
   they need to be escaped before passing as `-run` flag value
   that assumes regexp. We split around '/' and then escape meta
   characters using escapeRegExp.

2. A bug in getOrCreateSubTest's child search prevented
   looking up a node for the nested subtest. We should've compared
   label with label. Added comments to clarify the difference
   between label and name.

Fixes golang/vscode-go#3070
Fixes golang/vscode-go#2624
For golang/vscode-go#3022 (even though the issue is for the codelens)

Change-Id: I250d1188e91679aee5704e1bccfcd2344cf1ae90
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/546260
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>