tree 0edf31b6e41999b59627d27680e3be674caf0e17
parent 9f790f818e3dfd25bbf9e60e8c91fec1301c4266
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> 1595893900 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1595967329 +0000

src/goEnvironmentStatus.ts: use the new EnvironmentVariableCollection API

vscode.ExtensionContext.EnvironmentVariableCollection is available since
1.46 (May 2020 release https://code.visualstudio.com/updates/v1_46#_environment-variable-collection)
This API is specifically designed to help easy mutation of terminal
environment, so we are trying to use it now.

I hope this helps to address a couple of bugs related to the shell
detection and the correct command and path escaping discovered
during testing on Windows.

Unfortunately, this API does not work well on Mac
https://github.com/microsoft/vscode/issues/99878 due to the peculiarity
described in
https://code.visualstudio.com/docs/editor/integrated-terminal#_why-are-there-duplicate-paths-in-the-terminals-path-environment-variable-andor-why-are-they-reversed

So, we use the new API only for non-darwin OSes for now. On Mac,
we send the command as done before unless users explicitly
chose to use `-l` or `--login` parameter.

And moved addGoRuntimeBaseToPATH to goEnvironmentStatus.ts
because I think this is a better place.

Updates golang/vscode-go#378

Change-Id: I56ada362fb422bca9c789eae30c6239cac5b4711
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/245127
Reviewed-by: Brayden Cloud <bcloud@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>