tree fff9ac1f3e3c8d448f98ec476b8613cede0134cd
parent 705272cba4001b8caf71a1542f376daa2e0be089
author Hana <hyangah@gmail.com> 1609294042 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1610125377 +0000

src/debugAdapter: add dlvFlags to accept arbitrary delve flags

Added the same to src/debugAdapter2. We don't do any flag validation
- that will be done by dlv. We place the user-specified flags before
the flags internally set up, so, when users specify flags that are used
internally (e.g. --listen) or that are configured through the debug
configuration properties (e.g. --log-output) as well, the flag values
internally set up can be picked up unless dlv complains about the
duplicated flags.

This flag property and other properties related to dlv flags are
currently passed as part of launch request args because the legacy DA
launches the delve process upon receiving the launch request. However,
I am not sure if that's still true when we switch to the delve DAP mode
and we can launch the delve DAP directly from the extension. For now,
I added dlvFlags to the delve DAP mode thin adapter too (like other
flag-related properties).

Fixes golang/vscode-go#810
Updates golang/vscode-go#978

Change-Id: Iaab6097d3357ccafc274cb0a4fc970f2b6945b66
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/280697
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Polina Sokolova <polina@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>