commit c8584f4fc2ec7adfc944482cbd5e17f46ca25f98
author Hana <hyangah@gmail.com> Tue Feb 01 18:15:42 2022 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Tue Feb 08 17:23:42 2022 +0000
tree 95aa293c0677d27a8679dc5cd06de89de35a0c30
parent c845547072ecd493f436fa12b2334bca0bb0867d

[release] src/goTest: avoid a name conflicting with the proposed quickpick api

src/goTest used an extended quickpick type that adds a custom property
'kind' to specify the profile type. Unfortunately, that conflicts with
the proposed API added during vscode 1.63 dev cycle and breaks the
extension's profile feature.

Rename ours to 'profilekind'.

And reenabled the profile feature tests disabled due to 1858.
(but these tests don't exercise the affected code path - quickpick
UI interaction)

Fixes golang/vscode-go#2048

Updates golang/vscode-go#1858

Change-Id: Iedd1c5f32cdbc8438e203f8989f28bfcaf1c04b4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/382334
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Ethan Reesor <ethan.reesor@gmail.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
(cherry picked from commit 037e8a3cf960e1f46a29b16a22e8daa817704ee3)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/383219
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>

src/goTest/profile.ts

diff --git a/src/goTest/profile.ts b/src/goTest/profile.ts
index f507bba..8d49511 100644
--- a/src/goTest/profile.ts
+++ b/src/goTest/profile.ts
@@ -76,16 +76,16 @@
 	}
 
 	async configure(): Promise<ProfilingOptions | undefined> {
-		const { kind } = await vscode.window.showQuickPick(
-			Kind.all.map((x) => ({ label: x.label, kind: x })),
+		const { profilekind } = await vscode.window.showQuickPick(
+			Kind.all.map((x) => ({ label: x.label, profilekind: x })),
 			{
 				title: 'Profile'
 			}
 		);
-		if (!kind) return;
+		if (!profilekind) return;
 
 		return {
-			kind: kind.id
+			kind: profilekind.id
 		};
 	}
 

test/integration/goTest.run.test.ts

diff --git a/test/integration/goTest.run.test.ts b/test/integration/goTest.run.test.ts
index e52d7df..b08cbc2 100644
--- a/test/integration/goTest.run.test.ts
+++ b/test/integration/goTest.run.test.ts
@@ -13,7 +13,7 @@
 
 	let testExplorer: GoTestExplorer;
 
-	suite.skip('Profile', () => {
+	suite('Profile', () => {
 		const sandbox = sinon.createSandbox();
 		const ctx = MockExtensionContext.new();