tree 2d2e2aa9e696d2ade1c28591675076dec2e4f356
parent cbdd3280a012791a7abfd2b66d9bf82dabfc57b3
author Hana <hyangah@gmail.com> 1621267980 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1621525192 +0000

src/goDebugFactory: connect after createDebugAdapterDescriptor

This is a partial revert of https://go-review.googlesource.com/c/vscode-go/+/313049

CL/313049 attempted to complete the launch + connect before returning
from createDebugAdapterDescriptor call. The intention was to detect
the problems early enough and simplify the code path. But it turned out
VSCode does not fully initialize the debug session and its associated
resources such as a Debug Console before createDebugAdapterDescriptor
is complete. As a result, any log messages before the return are dropped
from Debug Console, which hurts usability/discoverability.

Revert the cl, but instead of lazily calling startAndConnectToServer
upon the very first sendMessageToServer call, call it from the
constructor.  We will need it anyway even when we disconnect
without sending any message before.

logDest test suite is temporarily disabled because the test
depends on createDebugAdapterDescriptor's failure when invalid
logDest is specified.

Change-Id: I980dd27e265133274b8f98bbfddc3a40160e115e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/320432
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>