tree 1b7158cd79b4938d135f719ae32fe3166ad24f98
parent 4dd972eb0de8849c3207c3bf981bcad7471e9f9c
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> 1656351213 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1656446606 +0000

src/language/goLanguageServer: remove redundant error popups from custom error handler

From vscode-languageclient v8.0.x (LSP 3.17), the language client reports the start
errors specially and surfaces them as user visible popups regardless revealOutputChannelOn
setting. Thus, our error popups are no longer necessary. Remove this.

When an error occurs during initialization, the connection to the server shuts
down which triggers the close handler. Previously, we suggested gopls issue
report from both initializationFailedHandler and errorHandler.closed handler.
That now results in two gopls issue report suggestions. Instead, stash the
initialization failure error, and handle the suggestion prompt from one place.

Note - in case of initializtion error, there is no point of retrying 5 times.

We also explicitly set the error & connection close handlers messages to empty
when requesting for continue/restart action, which will suppresses the default
error message popups.

While we are here, we improve the go status bar's language server state report
by updating it when the language server connection close is obeserved.

Updates microsoft/vscode-languageserver-node#1011
Fixes golang/vscode-go#2300

Change-Id: I8b20cf11ebb61ab474950440fc46ff23f7b0b826
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/414457
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>