tree 3e75602f83da982701241ea716b8bab45611c517
parent c0e33de4263469e1c6bc25b4723ca19212ea4682
author Hana <hyangah@gmail.com> 1631596129 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1631645658 +0000

src/goDebugConfiguration: do not merge toolExecutionEnvironment to 'env'

toolExecutionEnvironment is populated based on settings.json. The extension
merged these env vars into 'env' automatically in order to make the separate
legacy debug adapter process use the same env vars when invoking `dlv`.

In dlv-dap mode, the extension host spawns dlv processes and can control
the environment variables easily. Instead of mutating the launch parameter's
env property by merging the toolExecutionEnvironment, this CL uses the
env vars only when spawning the dlv process.

This makes the debug adapter trace's launch message logging more compact
and easier to share/inspect the request.

Change-Id: I352528e4907e9b62e79c0f2b4d79f97fcd32c5dc
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/349749
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>