tree 087dfda43297c65ca744fc7c370d50817d3258d8
parent 27e8258de8d3b5d863e9ba84a0e9b8a8bd7e1b5f
author Hana <hyangah@gmail.com> 1651149773 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1651253218 +0000

src/goLanguageServer: timeout LanguageClient.stop call

LanguageClient.stop hangs indefinitely if the language server
fails to respond to the `shutdown` request. For example, in
go.dev/issues/52543 we observed `gopls` crashes during
shutdown.

Implement a timeout from our side. (2sec)

Caveat:
If gopls is still active but fails to respond within 2sec,
it's possible that we may end up having multiple
gopls instances briefly until the previous gopls completes
the shutdown process.

For golang/vscode-go#1896
For golang/vscode-go#2222

Change-Id: Idbcfd3ee5f94fd3fd8dcafa228c6f03f5e14b905
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/402834
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>