tree 441af460fd12c3242a9ab21b1ec88a9ccb62859f
parent b2f6fcf660e805b7fad9417349894468593339d4
author Hana <hyangah@gmail.com> 1619189971 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1619460862 +0000

src/goDebugFactory: use --log-dest to capture dlv logs and add logDest

The old debug adapter's verbose log was written to vscode-go-debug.txt
by typescript LoggingDebugSession. Now dlv dap is replacing the old
adapter, and its verbose log messages are controlled by dlv's
--log, --log-output, and --log-dest.

dlv's --log-dest can accept a file descriptor number. This PR utilizes
it so it can cleanly distinguish delve's logging from debugee's
stdout/stderr. The logging messages with 'console' category - vscode
will present console messages with a different color so it will be
easily distinghishable from stderr/stdout.

For users who want to use dlv's --log-dest to write delve logs to a
file, this PR introduces a new debug config attribute `logDest`.
If this is set, the debug adapter writes the log message to the file
instead of showing it in DEBUG CONSOLE. (maybe we can revisit this
later and change to show the log messages in DEBUG CONSOLE as well)

This new attribute isn't supposed to be used by dlv dap or used to
set --log-dest when launching the dlv dap.

Fixes golang/vscode-go#1407

Change-Id: I8ea0a8d93fabee5c6aa5f8d5e46064d2ebd3958d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/313050
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>