tree a171756b73a7f79db67cda5a30b273b32e1abee5
parent 93ee1d22ac928171e045acabe97e4e91a850a716
author Hana <hyangah@gmail.com> 1616542352 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1616705851 +0000

src/goDebugFactory: don't use env['dlvPath']

The code that processes 'dlvPath' from the environment variables
was added in https://go-review.googlesource.com/c/vscode-go/+/240417/15/src/debugAdapter2/goDlvDebug.ts#555
That added one more way to configure the delve binary path
in addition to "go.alternateTools" setting. The benefit of
this extra config path is unclear, so let's delete it.

If we ever decide to allow users to configure the dlv tool
location from launch.json differently from what the
extension picks by default, we should use 'dlvToolPath'
attribute directly, rather than introducing another way
and asking users to set it through the 'env' attribute.

Change-Id: I52fd2a90029973c37787667c698019c2d456adce
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/304289
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Polina Sokolova <polina@google.com>