tree 16f1ffd76ee891194250d557d48134bf2f90b481
parent 318539dc9b629b5862e1568e11d2e427ba5cefe4
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> 1667266063 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1667316419 +0000

src/language/goLanguageServer: fix signature help trigger injection

Triggering signature help after completion was implemented by
injecting the followup command for each Method/Function type completion
item from the middleware. Unfortunately, we used a wrong enum
(lsp proto CompletionItemKind instead of vscode API's CompletionItemKind).
LSP enums are 0-based, while vscode API's enums are 1-based. As a result,
we failed to correctly inject trigger parameter hint action for Method
type completion items.

For golang/vscode-go#2515

Change-Id: Ib75dd8f14f421aad9b2a2682a8e7e0621b2effd9
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/446816
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Peter Weinberger <pjw@google.com>