extension/test/gopls: fix writeVulns tests
The tests were broken after gopls@v0.16.0 release.
That is because x/vuln dependency was updated and x/vuln/cmd/govulncheck
no longer includes the text pattern the test depended on to detect the
output stream.
Update the text pattern. The output stream should end either with
"vulnerabilities found" or "No vulnerabilities found".
Change-Id: I312a42b8439fb0a4e372323aa479ee7e91d2b018
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/593658
kokoro-CI: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
diff --git a/extension/test/gopls/vulncheck.test.ts b/extension/test/gopls/vulncheck.test.ts
index b9b19e3..7c92ea6 100644
--- a/extension/test/gopls/vulncheck.test.ts
+++ b/extension/test/gopls/vulncheck.test.ts
@@ -60,11 +60,9 @@
test('govulncheck finds vulnerabilities', async () => {
const workspaceDir = path.join(fixtureDir, 'mod1');
const output = await testRunGovulncheck(workspaceDir);
- const sections = output.toString().split(' Informational ');
- assert(sections.length >= 2, `got ${JSON.stringify(sections)}`);
- assert(sections[0].includes('GO-1970-TEXT'));
- assert(sections[1].includes('GO-1970-FMT'));
- assert(sections[1].includes('vulnerabilities found'));
+ const result = output.toString();
+ assert(result.includes('GO-1970-TEXT'));
+ assert(result.includes('vulnerabilities found'));
});
test('govulncheck finds no vulnerabilities', async () => {
@@ -85,7 +83,7 @@
};
return await languageClient?.sendRequest(ExecuteCommandRequest.type, params);
});
- const msg = 'Share feedback';
+ const msg = 'vulnerabilities found';
const timeoutMS = 10000;
await new Promise<void>((resolve, reject) => {
const timeout = setTimeout(() => {
