tree 246a287473d30eb0ce49a85ef3a95677864e407d
parent 730d202c404767dd21bd9224954e194fc2637782
author Hana <hyangah@gmail.com> 1618608321 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1620233967 +0000

src/goMain: overwrite process.env[GOROOT] if go.goroot is set

Moreover, if go.goroot is set or process.env[GOROOT] is not empty,
disallow go.environment.choose command.

And, fix addGoRuntimeBaseToPATH on macOS (on MacOS, we depend
on the terminalCreationListener to reflect the update PATH to
the terminal. When it is changed, we should dispose the previous
listener and set up a new one).

Change-Id: I497eadc7f0994c861cf597d8d5c6e9a5e9b1258b
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/310853
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>