tree c4c6a7216be9a4649eded0277a6fbd5d575601e3
parent c449a4cbc56731ce0d835799e6ef4b38d2572812
author Oleg Butuzov <butuzov@made.ua> 1595865489 +0000
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1595867288 +0000

src/goLint.ts: fixes a golangci-lint integration issue

golangci-lint outputs the analysis results in stdout, but sometimes uses stderr to print non-critical error or warning messages. For example, when `nolintlint` is enabled, some issues are reported in stderr. That is not a lint error, but outputting the log messages in stderr breaks the current assumption `runTool` in `util.ts` makes.

As a low-risk workaround, this CL forces `golangci-lint` to always exit with 0 using its `--issues-exit-code`. That will prevent `runTool` from thinking the tool failed and bailing out early.

Fixes golang/vscode-go#411.

Change-Id: Ief5d2ca464ad5b7ad8f24a652679a99cae005b26
GitHub-Last-Rev: 1c64b284ea3fcb2c9b68d208b3c516682673ff74
GitHub-Pull-Request: golang/vscode-go#412
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/244801
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>