tree 3f2d8b41ad9fbd4fc495cfac254fb04170c93688
parent f0c87a6e05b54e79046db83b276a659a1781d4aa
author Hana <hyangah@gmail.com> 1603215056 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1603232029 +0000

src/goInstallTools: use the 'go' command from GOROOT/bin for tool install

For tools installation, we run `go get` from a temporary directory in order
to use the clean module-aware go build mode. This causes an issue in
environments where the choice of go is determined by the current directory.
In this change we pin the go version by using GOROOT/bin/go{.exe} instead
of the go binary bin path.

Note: We tried to address this issue by running the go command with a
temporary -modfile in the current workspace directory. Unfortunately,
that approach turned out to be more complicated than expected.

And add verbose logging for the installation logic (can be enabled by
'"go.logging.level": "verbose"'

Fixes golang/vscode-go#757

Change-Id: I7ab792a494a38dcb6b2f6fc8891fa96af5c29380
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/263977
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>