tree 6e056d8fe57f8e440561d6ee66bf49730cfde7f5
parent 893333d7aa82941018b1714c1ad486ad35c78303
author Vincent Jo <vincentjo@google.com> 1591985439 +0000
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1591994749 +0000

src/debugAdapter: adds error handling for remote connections

json-rpc2 module doesn't catch all the errors in its callback. If a remote connection fails to be established, it won't call the callback for errors. So the connection will hang. There are no future plans to handle the error case through the callback: json-rpc2: pocesar/node-jsonrpc2#53. Node.js handles errors in a similar way: https://nodejs.org/api/net.html#net_socket_connect. Errors won't be exposed through the callback, only through the error listener.

Fixes golang/vscode-go#215

Change-Id: I75cfb2a0cf6628a8c35ddccf8c96ec1ade0275f1
GitHub-Last-Rev: 44d9b592e068a1136a0c41c10fcdfab68f64fe0a
GitHub-Pull-Request: golang/vscode-go#216
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237559
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>