tree a80021fab7c9859ebbe76f0fd6e674e6375232e6
parent f8f54337ec824f27d692d46f5f84a2f24651ea6a
author Hana <hyangah@gmail.com> 1617258671 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1617301825 +0000

test/integration: use DelveDAPOutputAdapter in dlv-dap mode testing

Previously, dlv-dap mode tests directly spawned a dlv dap server
and made the debug client directly connect to it. This change makes
the tests use DelveDAPOutputAdapter the extension uses to spawn
a dlv dap server and proxies DAP requests/responses and its
stdout/stderr. This allows to see the debugee's output and test
the most fragile, complex part in the new adapter integration.

The test support library only works debug adapters that implements
DAP protocol server (JSON encoding/decoding over a network socket
or stdin/out). DelveDAPDebugAdapterOnSocket is an extension of
DelveDAPOutputAdapter that adds JSON protocol encoding/decoding
over a network socket. Tests now create a DelveDAPDebugAdapterOnSocket
and connect the DebugClient with its network port.

DelveDAPDebugAdapterOnSocket provides another vantage point to
trace DAP protocol exchange, so we use that to capture the traffic
and print the captured traffic only if the current test fails.

I think this thin adapter and the support code is getting too
complex. I am planning to try a different approach to get rid of
this thin adapter again for simplicity.

Change-Id: I3215ceea77b75c4f859ab5f948935f6485f28a11
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/306590
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>