tree a6b0f7072439620f819e1198ca0cd18ad25a242f
parent 2a643dec8e15ea0b2a1893433f030aa51d58b638
author Hana <hyangah@gmail.com> 1607369829 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1607541710 +0000

src/goInstallTools: fix gocode-gomod installation path

Should consider GOBIN, and then GOPATH.

Gets rid of the 'unexpected directory layout' condition handling.
The code path isn't reachable if the go command ever fails with the error.
(the first execFile will fail and causes an exception).

While we are here, improve the failed tool installation error message
by outputting the details of the failure including whether the command
failed with signals, what's code exit code, etc.
And, also set the default output to be 'no output', since otherwise
users will see 'undefined' as an error message which carries no info.

Change-Id: I2e14d2e4aa5f64831a5bb8b6487a670ddfa014f4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/275877
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>