tree 492769707fe5798b9e7da7d9394f29d1950f2a1b
parent 603c3de10f6c962488dc06a3740a52776711fe69
author Ryan Koski <ryan@koski.org> 1590588536 +0000
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1590592604 +0000

use the GOBIN value reported by go env

Teach vscode-go to use the value of GOBIN as reported by `go env`. This is beneficial when VSCode is launched outside of a terminal (e.g. - macOS Dock) where the user's environment variables may not be available.

If GOBIN had been set via `go env -w GOBIN=...`, then the go tools installed by the extension would be deployed there, but the extension would not end up finding them because it only looked for GOBIN as an environment variable. It looks like the extension already supported reading GOROOT, GOPATH, and GOPROXY from `go env`, so this adds GOBIN.

Change-Id: Ib3b0db1d30ae91f2e8ca721f6c7f71eefff41728
GitHub-Last-Rev: a9aade765158475343f4366a8dbcf003a85957ae
GitHub-Pull-Request: golang/vscode-go#93
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/235197
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>