tree fe64eb169d1036425d81362cbe181072f54822ec
parent 15ba816f7392d97a4c19aaabc94896d451835703
author Hana Kim <hyangah@gmail.com> 1604604277 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1605640876 +0000

src/goEnvironmentStatus: correctly interpret the chosen go path

In order to retrieve the file path to the go binary chosen
from the file browser, we should use fsPath, instead of path.

While we are here, we also address two additional issues:

- Enhance the validation of `go version` result by checking
the returned GoVersion object is valid. Binary that implements
`version` but outputs a version string that's not recognizable
will be rejected.

- Make chooseGoEnvironment handle failed getDefaultGoOption call
so users can still have QuickPick items to clear the incorrect
value stored in the Memento or choose a different version.

Fixes golang/vscode-go#868
Fixes golang/vscode-go#864

Change-Id: Ib0a3762ff3851c5a88ee5bde0fdc84c865060f6e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/267898
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>