)]}' { "commit": "2e4a9cf51ebf922ee8a42e2738971ea8310d30d1", "tree": "a236cbe39aec75cc44e94604e4d9929ab56f6a23", "parents": [ "92b8c737e7eeaf2ab6c133a50b58e7959932bc39" ], "author": { "name": "Hana (Hyang-Ah) Kim", "email": "hyangah@gmail.com", "time": "Wed Jul 22 14:00:35 2020 -0400" }, "committer": { "name": "Hyang-Ah Hana Kim", "email": "hyangah@gmail.com", "time": "Wed Jul 22 21:50:59 2020 +0000" }, "message": "utils/processUtils: check if the process is running before killing\n\nCheck ChildProcess.exitCode before starting to kill the process.\nAccording to https://nodejs.org/api/child_process.html#child_process_subprocess_exitcode\nthis should be null if it\u0027s still running.\n(note the exitCode can be still null after a process terminates.)\n\nAnd remove some logging messages that looked too verbose and\nflooded the console.\n\nFixes golang/vscode-go#334\n\nChange-Id: I04161806ba6160f9152ce17618b38f96f82b732c\nReviewed-on: https://go-review.googlesource.com/c/vscode-go/+/244359\nReviewed-by: Eli Bendersky \u003celiben@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "5c6d3434bdc8ccec3d6b98e61f98f93da5d62a55", "old_mode": 33188, "old_path": "src/utils/processUtils.ts", "new_id": "ddd12ae5088227ce77131aa2d618fe067d6fd2ab", "new_mode": 33188, "new_path": "src/utils/processUtils.ts" } ] }