tree 57467bfed8b37c21091b78f4e86dd8bfc527bfca
parent 2e739cc05022296cab0cd7aa1919de948a595f21
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> 1665685410 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1666031067 +0000

src/goToolsInformation: fix go-outline version

There is no v1.0.0 version.

The tagging of go-outline project doesn't follow go modules
versioning convention, so the release tag version is not
recognized.

Since we pinned the 3rd party tools versions after
https://go-review.googlesource.com/c/vscode-go/+/435375
we also need to adjust the code path that pick the version
of tools whose latest versions require go 1.18+ to build.
Use Tool.defaultVersion only if we are handling these special
cases. (gofumpt, golangci-lint, staticcheck)

Also, set GOMODCACHE explicitly when interacting with the
fake local proxy. When the test runs in an environment with
GOMODCACHE is set, the test ends up polluting the specified
GOMODCACHE with fake data from the local test proxy. Our
intention was to use GOPATH[0]/pkg/mod as module cache
during the test.

Fixes golang/vscode-go#2485
Updates golang/vscode-go#1850

Change-Id: Iad6cb662f637d444b9a8047db2aa166965144db8
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/442786
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>