tree f39762a3a7d7ad0a690ed9c3f15959e123ac7ffa
parent dfdd910242c52db5cf71ff399b62a39d7934cda3
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> 1600900114 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1601323454 +0000

[release] src/goInstallTools.ts: mutate PATH only when necessary

When the extension chooses a different version of go
than the one from the system default - because the user
has configured `go.goroot` or `go.alternateTools.go`, or
used the `Go: Choose Go Environment` command - the extension
mutates the `PATH` (or `Path` on windows) environment variable
so all the underlying tools pick the same go version.
It also changes the environment variable collection used
in the integrated terminal so when the user invokes `go`
from the terminal, they use the go version consistent
with the extension.

But this behavior can conflict with external version
management software. Change the PATH environment only
if the extension is configured to choose the go binary.

Fixes golang/vscode-go#679.
Update golang/vscode-go#544.

Change-Id: I9f7acb26b752ed33dbde2b238a67ed09616b43e5
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/256938
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
(cherry picked from commit ab4b257d907f29879886ba1855202412bae6793b)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/258077