tree 2b7300f4b9a76ba7bedebe76506229733a9760b9
parent 337e5331586b636ed2880725ef7f28a7c9a527f4
author Hana <hyangah@gmail.com> 1633450787 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1633969757 +0000

src/goDebugConfiguration: handle directory with '.' in its name

parseProgramSync assumed 'program' is a directory if it does not
contain '.'. That was a hack to avoid lstatSync and implement/test
parseProgramSync without requiring the program to be a valid,
existing file or directory. However, this does not work for users
whose folder name contains '.'. (e.g., golang/vscode-go#1826)
Readd the lstat check to examine whether the program is a directory.
This required to change tests to create dummy files and folders.

While we are here, rework parseProgramSync.
 - move parseProgramSync to goDebugConfiguration, the only call
   site of this function.
 - rename it to parseDebugProgramArgSync and call it only for
   debug/test/auto launch requests.
 - call parseDebugProgramArgSync for externally launched debug
   adapter settings too because it does `program` validation.
   But in that case, we won't mess with `program` or `__buildDir`.
 - previously we accepted cases for which parseDebugProgramArgSync
   throws an error (including files other than .go) because the
   hack is not perfect and delve dap and go build may know better
   on how to handle that. But now build errors can be hidden in DEBUG
   CONSOLE so they fail to catch users' attention
   (e.g., golang/vscode-go#1826)
   So, let's stop and don't proceed if parseDebugProgramArgSync fails.

Updates golang/vscode-go#1769
Updates golang/vscode-go#1826

Change-Id: If413a0ca0c5814bcaa45ea69ceff8bcfde558370
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/353990
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>