tree cb5bdcf68767da0393b79fb46a55259f07a960ab
parent b15a5cc97f9661cea70a7a9ba7e0f3c84e700627
author Hana <hyangah@gmail.com> 1610421479 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1610667485 +0000

src/config: add Configuration class to encapsulate the extension settings

Configuration's get returns the 'go' section of the vscode settings.
This wraps the vscode.WorkspaceConfiguration object that would be returned
by vscode.workspace.getConfiguration, but this prevents it from returning
values from the workspace/workspaceFolder level settings if the queried
key is security-sensitive - e.g. use of workspace level settings from
the untrusted repository may result in arbitrary binary execution.

This CL does not use the new Configuration from the extension yet.

For golang/vscode-go#1094

Change-Id: Ia75389032dfaec300506b26ab839b173ff9e5557
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/283253
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>