tree 702e106ad4cd37e8160f51c12c183d5e3b1d2200
parent cda36bef4246a6fb6cea0fdeb354df9684156fc6
author Hana <hyangah@gmail.com> 1610079981 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1610150022 +0000

src/goLanguageServer: fix a bug that prevented gopls start after forced update

When gopls is too old, the extension triggers the update of gopls, expecting that
gopls restart logic to run following the completion of the gopls update.
The restart logic kicks in, but the languageServerStartInProgress flag introduced
by change from https://go-review.googlesource.com/c/vscode-go/+/274250
to prevent restart request racing prevents the actual restart.

Set the languageServerStartInProgress flag just before starting the actual restart.

Testing is tricky - manually tested by building the extension with gopls enabled
by default and using an old gopls version.

Change-Id: I31f1144e82c2563c844e10cdd017ae3974f4c199
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/282593
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>