)]}' { "commit": "0359d7001592312105aab5998e77488da99740c5", "tree": "a874e72c891d0cf7a1a698b109fcdd2ddf282dbd", "parents": [ "411be4c33898903e627cc3a6962e8800fba23e30" ], "author": { "name": "Hana (Hyang-Ah) Kim", "email": "hyangah@gmail.com", "time": "Wed Jul 01 21:51:38 2020 -0400" }, "committer": { "name": "Hyang-Ah Hana Kim", "email": "hyangah@gmail.com", "time": "Thu Jul 02 18:38:02 2020 +0000" }, "message": "src/goEnvironmentStatus: remove a circular dependency\n\ngoInstallTools.ts imports goEnvironmentStatus.ts for initGoStatusBar.\ngoEnvironmentStatus.ts imported goInstallTools.ts for getActiveGoRoot.\n\nThe caller of getActiveGoRoot is the chooseGoEnvironment command\nthat is activated only after initGoStatusBar is called.\ninitGoStatusBar is called after updateGoVarsFromConfig, so calling\nupdateGoVarsFromConfig in getActiveGoRoot is unnecessary.\n\nThis CL replaces getActiveGoRoot with getCurrentGoRoot,\nwhich removes the need to import goInstallTools.ts from\ngoEnvironmentStatus.ts.\n\nChange-Id: I79320bd22fae7470c28dfd7f883a77b3a3c177a2\nReviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240694\nReviewed-by: Rebecca Stambler \u003crstambler@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "4f24e85fc87ef45be497cbe4387e1c78c201e501", "old_mode": 33188, "old_path": "src/goEnvironmentStatus.ts", "new_id": "154803b7e7faa1b5fff55a0922f66a5862a6b5fa", "new_mode": 33188, "new_path": "src/goEnvironmentStatus.ts" }, { "type": "modify", "old_id": "330fabb06c4819bdc1aa84cb1738da9d02b01c21", "old_mode": 33188, "old_path": "src/goInstallTools.ts", "new_id": "372280764d22272cb77f6a6024a41a79deae3776", "new_mode": 33188, "new_path": "src/goInstallTools.ts" } ] }