tree 158b86ab92d156006f57747ca52d2366d9c51629
parent 10509fb7d6551e02a7074c97eb5e55630183bbcb
author Hana <hyangah@gmail.com> 1618589784 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1618611788 +0000

src/goInstallTools: use GOBIN correctly installing dlv-dap/gocode-gomod

We incorrectly added `bin` to the final binary path
when the destination was determined by GOBIN env var.

Changed install.test.ts to set the temporary GOPATH instead of
stubbing getToolsGopath. When populating tools installation
environment, the extension ignores GOBIN if users configured
go.toolsGopath currently, so depending on toolsGopath to point
to the temporary GOPATH prevents from testing GOBIN-related
behavior.

Fixes golang/vscode-go#1430

Change-Id: Id6450e9422a791f6d5e7810f6bbbec1bc695e924
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/310769
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>