tree 32e5be8a6af7a11509d10fdde2d4852da8e8abca
parent 8f8669e543c745dc1cc5ab946e529dfd0c38dc1c
author Russ Cox <rsc@golang.org> 1530818376 -0400
committer Russ Cox <rsc@golang.org> 1531365461 +0000

cmd/go/internal/modfetch: add detail to "missing go.mod" errors

Explain what's wrong better than "missing or invalid go.mod".
While we're here, improve the signal-to-noise ratio too.

Before this CL, using the scenario from golang/go#24522:

$ vgo get github.com/rsc/blackfriday/v2
go: github.com/rsc/blackfriday/v2 v2.0.1: missing or invalid go.mod
go get github.com/rsc/blackfriday/v2: missing or invalid go.mod

$ vgo get github.com/rsc/blackfriday/v2@v2.0.1-bad
go: github.com/rsc/blackfriday/v2 v2.0.1-bad: missing or invalid go.mod
go get github.com/rsc/blackfriday/v2@v2.0.1-bad: missing or invalid go.mod

After this CL:

$ vgo get github.com/rsc/blackfriday/v2
go: github.com/rsc/blackfriday/v2@v2.0.0: missing github.com/rsc/blackfriday/go.mod and .../v2/go.mod at revision v2.0.0
go: error loading module requirements

$ vgo get github.com/rsc/blackfriday/v2@v2.0.1-bad
go: github.com/rsc/blackfriday/v2@v2.0.1-bad: go.mod has non-.../v2 module path "github.com/rsc/blackfriday" (and .../v2/go.mod does not exist) at revision v2.0.1-bad
go: error loading module requirements

Fixes golang/go#24522.

Change-Id: I1471729cdde8345130d771f26b1501638b7452d2
Reviewed-on: https://go-review.googlesource.com/122399
Reviewed-by: Bryan C. Mills <bcmills@google.com>