tree 57457119ece2bd82714537b506839b9614473652
parent 0f3e556044ecbd8a0805d098e52a743a1d0e3566
author Russ Cox <rsc@golang.org> 1529511384 -0400
committer Russ Cox <rsc@golang.org> 1530125902 +0000

cmd/go/internal/modfetch/gitrepo: simplify and cache git access

This CL drops the Root method from codehost.Repo,
since a codehost.Repo is really just about access to a source tree.
It has no real knowledge of anything related to modules or
import paths, so the Root method was out of place.

Dropping Root and then caching gitrepo by remote
should guarantee that there is at most one *gitrepo.repo
for a particular vcswork checkout directory.

Add a lock to codehost.Run to guarantee that at most one
command runs in a directory at a time. This should not
be strictly necessary now, but it lets bugs be just inefficiencies
instead of crashes.

Change-Id: I983c7a4691de3a0aa809c1af61679b48a77667e0
Reviewed-on: https://go-review.googlesource.com/120041
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>