commit 86c5873b4804d5d9d184ac147f98e9652a0fa258
author Daniel Martí <mvdan@mvdan.cc> Tue Feb 26 13:40:04 2019 +0100
committer Brad Fitzpatrick <bradfitz@golang.org> Wed Mar 13 20:59:20 2019 +0000
tree db089312378b7ef25c58f6417884df09eca762a9
parent 49d818b07734fb3230f2d00bc5d4453348348d24

[release-branch.go1.12] go/analysis/passes/printf: fix big.Int false positive

It's possible to use a type which implements fmt.Formatter without
importing fmt directly, if the type is imported from another package
such as math/big.

On top of that, it's possible to use printf-like functions without
importing fmt directly, such as using testing.T.Logf.

These two scenarios combined can lead to the printf check not finding
the fmt.Formatter type, since it's not a direct dependency of the root
package.

fmt must still be in the import graph somewhere, so we could search for
it via types.Package.Imports. However, at that point it's simpler to
just look for the Format method manually via go/types.

Fixes #30399.

Change-Id: Id78454bb6a51b3c5e1bcb1984a7fbfb4a29a5be0
Reviewed-on: https://go-review.googlesource.com/c/163817
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
(cherry picked from commit 589c23e65e65055d47b9ad4a99723bc389136265)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/164657
Run-TryBot: Alan Donovan <adonovan@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>