| commit | 41e4e565498859435a2ad44a71cf6701a6afb585 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Tue Jun 13 15:43:44 2023 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Wed Jun 14 19:51:45 2023 +0000 |
| tree | 6e3dfe2267da1b8906a1218301fd2bc47b925cfd | |
| parent | ac2946029ad3806349fa00546449da9f59320e89 [diff] |
gopls/internal/lsp/source/completion: ensuring completion completeness Ensure that completion processes at least depth=0 elements, by switching to a different model for truncating search. Don't encode the search deadline in the context, as the handling for context cancellation should differ from the handling of being out of budget. For example, we should not fail to format a completion item if we are out of budget. While at it, don't include type checking time in the completion budget, as it is highly variable and depends on the ordering of requests from the client: for example, if the client has already requested code lens, then the type-checked package will already exist and completion will not include type-checking in the budget. No documentation needs to be updated as the current documentation already says "this normally takes milliseconds", which can only be true if it doesn't include type checking. Also add a regression test that asserts we find all struct fields in completion results. Fixes golang/go#53992 Change-Id: I1aeb749cf64052b6a444166638a78b9945964e84 Reviewed-on: https://go-review.googlesource.com/c/tools/+/503016 Auto-Submit: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.