tree d1b86830f4a6fed537ca7ee57abc4d624d981254
parent 486f59bc617f48a749d07017d8aedace04a21f95
author Rebecca Stambler <rstambler@golang.org> 1586144902 -0400
committer Rebecca Stambler <rstambler@golang.org> 1586207999 +0000

internal/lsp: make sure that `gofmt -s` analyses don't modify AST

The code for `gofmt -s` directly modifies the AST, since the ASTs are
not long-lived. Some of this code made it into our analysis
implementations, causing very strange bugs to manifest. Added a
regression test for this specific case.

Fixes golang/go#38267

Change-Id: I235620adcbf2bbc7027c6d83ff2c7fe74729062e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/227299
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 1fd976651f4da6cc8c239c50463fb2d82641fa77)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/227354
Reviewed-by: Robert Findley <rfindley@google.com>