tree 91e0c7f343224797db5927d002a6fe9a896df71d
parent 082fc5838054c904b894bddc2447c812d1f12ec4
author Robert Findley <rfindley@google.com> 1670629084 -0500
committer Robert Findley <rfindley@google.com> 1670860343 +0000

[gopls-release-branch.0.11] gopls/internal/lsp/cache: record parse keys when they're created

When we parse a file through snapshot.ParseGo, we must record the parse
key by its URI for later invalidation. This wasn't done, resulting in a
memory leak.

Fix the leak by actually recording parse keys in the parseKeysByURI map,
which was previously always empty.

Write a test that diffs the cache before and after a change, which would
have caught this bug (and others).

Fixes golang/go#57222

Change-Id: I308812bf1030276dff08c26d359433750f44849a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456642
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
(cherry picked from commit a3eef2595adfe42f26e607e25f136b5d5388419c)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/456815