tree 3573a14419bfb1b678a14454da251daca13cab1e
parent 09a89eebd82fe6f7b165587296fdaaa218f57e2f
author Alan Donovan <adonovan@google.com> 1666973221 -0400
committer Gopher Robot <gobot@golang.org> 1666981495 +0000

[gopls-release-branch.0.10] internal/lsp/source: optimize filter regular expression

When the default filter glob changed to **/node_modules,
the performance of BenchmarkWorkspaceSymbols was observed
to degrade by an astonishing 20%.

(CPU profiles of the benchmark reported that the Disallow
functions percentage had increased only slightly, but these
measures are misleading since the benchmark has a very
CPU-intensive set-up step, so all the percentages are
quotients of this figure, masking their relative importance
to the small region during which the benchmark timer is
running.)

This change removes the unnecessary ^.* prefix from the
generated regular expression. Really the regexp package
ought to do this.

Also, minor cleanups and tweaks to the surrounding code.

Change-Id: I806aad810ce2e7bbfb2c9b04009d8db752a3b10d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/446177
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
(cherry picked from commit f1c8f7f8d5ac22654e879bbaa5c6887bb3782733)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/446181
Auto-Submit: Alan Donovan <adonovan@google.com>