)]}' { "commit": "aa82965741a9fecd12b026fbb3d3c6ed3231b8f8", "tree": "2bba10f09f01c9d11fa2d2e3c3f41804e7880644", "parents": [ "86c5873b4804d5d9d184ac147f98e9652a0fa258" ], "author": { "name": "Daniel Martí", "email": "mvdan@mvdan.cc", "time": "Fri Mar 01 11:00:19 2019 +0000" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Wed Mar 13 21:06:03 2019 +0000" }, "message": "[release-branch.go1.12] go/analysis: disable embedded struct tag check\n\nThis disables the enhancement added in golang.org/cl/115677. The\noriginal change was done in the old cmd/vet location, so it would be\nnon-trivial to port a full revert of all the code changes. Simply\nskipping anonymous struct fields is a simpler way to undo the effects of\nthe CL.\n\nThe reason we want to disable this enhancement of the check in the Go\n1.12 release branch is because a false positive was uncovered, which we\nwant fixed for Go 1.12.1. It\u0027s possible that the check will instead be\ntweaked for 1.13, but for 1.12.1 we want to play it safe.\n\nUpdates golang/go#30465.\n\nChange-Id: I379b4547a560723b8023dad45ab26556b10ee308\nReviewed-on: https://go-review.googlesource.com/c/tools/+/164659\nRun-TryBot: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "2b67c376bab8b9703d1b62d9a75f1601c8ec6d34", "old_mode": 33188, "old_path": "go/analysis/passes/structtag/structtag.go", "new_id": "5b27208e9185631f5049811f5b6eda781b26b6d9", "new_mode": 33188, "new_path": "go/analysis/passes/structtag/structtag.go" }, { "type": "modify", "old_id": "abb67fe4e5f4c1c6dcb7feb3ba204f6edc5d1264", "old_mode": 33188, "old_path": "go/analysis/passes/structtag/testdata/src/a/a.go", "new_id": "0078626dd09f159c2958ea169b5486bf7d7b245d", "new_mode": 33188, "new_path": "go/analysis/passes/structtag/testdata/src/a/a.go" } ] }