|author||Daniel Martí <firstname.lastname@example.org>||Tue Jan 08 23:48:41 2019 +0100|
|committer||Dmitri Shuralyov <email@example.com>||Mon Feb 25 22:47:41 2019 +0000|
[release-branch.go1.11] go/packages: make tests pass with custom GOCACHE This commit was merged earlier with some failing trybots, so it was reverted. This is a re-submission. Before this change, a test would fail: $ GOCACHE=$HOME/go/cache go test --- FAIL: TestLoadImportsGraph (1.05s) packages_test.go:225: subdir/d.test.Srcs = [cf570d60b25cde4f49bbe5f69d3ed407f2d7f1fbc500b8807da726fb19b8f588-d], want [0.go] FAIL This is because it assumed that the user hadn't set their own GOCACHE, and thus that all source files in the cache would be under the default "go-build" cache directory. We could fix this via os.Getenv("GOCACHE"), but a simpler mechanism is to see if the source file has an extension. Source files don't have an extension in GOCACHE, so that's much simpler to detect. After this change: $ GOCACHE=$HOME/go/cache go test PASS On release-branch.go1.11, golist_fallback.go did not yet have the code added that would need to be fixed, so nothing is being backported to it in this change. While at it, gofmt. Updates golang/go#29445 Fixes golang/go#29944 Change-Id: I21fc59f13f00bea1f9a8a80e0438825f1a36ac3e Reviewed-on: https://go-review.googlesource.com/c/156977 Run-TryBot: Brad Fitzpatrick <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Michael Matloob <firstname.lastname@example.org> Reviewed-on: https://go-review.googlesource.com/c/163780 Run-TryBot: Dmitri Shuralyov <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools,
vet for example, are included in binary Go distributions.
Others, including the Go
guru and the test coverage tool, can be fetched with
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run
go get -u golang.org/x/tools/.... You can also manually git clone the repository to
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.