internal/lsp: handle embedded struct pointer definitions

When jumping to definition of an embedded struct pointer, be sure to
unwrap the pointer type so you properly jump to the pointee type.

Also, fix jumping to definition of an embedded struct inside an
anonymous struct inside a struct. The embedded struct detection was
continuing too far and thinking it wasn't an embedded struct when it
saw the anonymous struct.

Fixes golang/go#31451

Change-Id: I96017764270712a2ae02a85306605495075d12e7
GitHub-Last-Rev: 9997f60855ebe37bcca2fecc1ba2a7b871f393d4
GitHub-Pull-Request: golang/tools#83
Run-TryBot: Paul Jolly <>
TryBot-Result: Gobot Gobot <>
Reviewed-by: Ian Cottrell <>
4 files changed
tree: f867bede401af4d9d11f4639b689743af8375a69
  1. .gitattributes
  2. .gitignore
  9. benchmark/
  10. blog/
  11. cmd/
  12. codereview.cfg
  13. container/
  14. cover/
  15. go.mod
  16. go.sum
  17. go/
  18. godoc/
  19. imports/
  20. internal/
  21. playground/
  22. present/
  23. refactor/

Go Tools

This subrepository holds the source for various packages and tools that support the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.

Others, including the Go guru and the test coverage tool, can be fetched with go get.

Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.


The easiest way to install is to run go get -u You can also manually git clone the repository to $GOPATH/src/

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see

The main issue tracker for the tools repository is located at Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.