tree 351e735f0c57c024d4f000b45b16568225d03e73
parent a721062d8b2d42bf1543f625fdf307ba37dab640
author Russ Cox <rsc@golang.org> 1688573240 -0400
committer Russ Cox <rsc@golang.org> 1689180277 +0000

go/analysis: pass package's Go version to type checker

Type checking of a package depends on the Go language version in
effect for that package. We have been not setting it and assuming
"latest" is good enough, but that is likely to become untrue in the
future, and it violates Go 1.21's emphasis on forward compatibility,
namely tools recognizing when they shouldn't be processing newer code.

Pass the Go version along from go/analysis to go/types, to allow
go/types to apply the version when type-checking.

In the one analysis pass that does its own type-checking (cgocall),
pass the Go version along explicitly there too.

Fixes golang/go#61174.
Fixes golang/go#61176.

Change-Id: I5a357f7c357c41b77d0eb83c905490cc1f866956
Reviewed-on: https://go-review.googlesource.com/c/tools/+/507880
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>