tree 024796a6df77e3856b1cd7d36bc5786e1455580d
parent 72cd703b6dfad20d9f6ccaf7bfc39ec422a43940
author Robert Findley <rfindley@google.com> 1687527176 -0400
committer Robert Findley <rfindley@google.com> 1687533606 +0000

gopls/internal/lsp/cache: don't panic when import fails during analysis

We have received a number of empty crash reports for gopls since cutting
the v0.12.3 release. We don't want to auto-populate crash reports with
log.Fatal messages (as unlike panicking stacks they may contain the name
of user packages), so in almost all cases we lose information as to why
gopls crashed (users are unlikely to pre-populate this information).

In general, I don't think failing analysis should crash the process, so
switch this failure mode to a bug report.

Fixes golang/go#60963

Change-Id: I670ee4b1adbe9f37d763c5684b14d4bcb78dcb63
Reviewed-on: https://go-review.googlesource.com/c/tools/+/505575
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit fa103593d02f86f400531e4294b9b294d4893901)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/505576