commit | 03e951c4abd217e6f1ae20cd8bb6d2d25e0fff8a | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Thu Oct 08 10:37:28 2020 -0400 |
committer | Robert Findley <rfindley@google.com> | Thu Oct 08 17:20:56 2020 +0000 |
tree | eeb7a60ac19fea1476df6a15a784ef480d5c1a5d | |
parent | 9df69603baec7844d33bef96918ac5dcb1be3326 [diff] |
internal/lsp/source: add an experimental new cache key for packages We've recently noted that hashing the packages.Config into the cache key for the type checked package is probably unnecessary, given that all the other critical inputs into the typechecker are already included (packageID, parsed files, and deps). Furthermore, when using a gopls daemon this causes unnecessary cache misses, because the packages.Config includes things like working directory that no longer matter once other inputs to type checking have been computed. Add an experiment flag that removes the packages.Config from the cache key. An experiment is used to stage this change as comprehensively testing the cache is ~impossible. Change-Id: I7ba73daaa71a80ec996decaa9817ec515b5eeb6e Reviewed-on: https://go-review.googlesource.com/c/tools/+/260737 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.