tree d5f73051c30b93e00fe09191e3b89b03bea7e622
parent 2d32e152db8505daf46592ba8ce716fa4d1dd145
author Robert Findley <rfindley@google.com> 1664889567 -0400
committer Robert Findley <rfindley@google.com> 1664992627 +0000

gopls/internal/lsp/source: don't type-check in FindPackageFromPos

In all cases where we call FindPackageFromPos, we know that the given
position must be in the forward transitive closure of an originating
package. Refactor to use this information, potentially saving
significant type-checking when searching for a package.

As a result of this change, we never need to search intermediate test
variants when querying PackagesForFile.

Also replace snapshot arguments with token.FileSet arguments, when the
snapshot is only needed for its FileSet.

For golang/go#55293

Change-Id: Icf6236bea76ab5105a6bab24ce3afc574147882b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/438495
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>