tree ff8860af2c8c0ccfd91e188162c2d8bd8a59599d
parent 636017e13115a0b661ec94f65281776762362657
author Rob Findley <rfindley@google.com> 1624636186 -0400
committer Robert Findley <rfindley@google.com> 1624648877 +0000

internal/jsonrpc2_v2: initialize async before binding

The lsprpc package needs to wait on the newly bound connection to
perform some tear-down, so it must be safe to call conn.Wait from Bind.

Achieve this by switching async from an init pattern to a constructor.
This means moving async fields to pointers, but since they weren't safe
to use prior to initialization anyway this feels correct.

Change-Id: I4f93980915e0b568fbf2db3cd7d062adf06e4b99
Reviewed-on: https://go-review.googlesource.com/c/tools/+/330929
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>