tree e7a933f9dcef963501391d1de7df02bbbe42fb96
parent 65e3620a7ae7ac25e8494a60f0e5ef4e4fba03b3
author Suzy Mueller <suzmue@golang.org> 1566425622 -0400
committer Suzy Mueller <suzmue@golang.org> 1566432191 +0000

internal/lsp: return error when renaming within an import spec

Since renaming an identifier within an import spec is not yet supported,
return an error when this is encountered. These idents from the import
spec have a nil declaration object.

Import paths that contain '.' or '/' are caught by the valid identifier check
avoiding the crash, but import paths such as "fmt" are not as fmt is a
valid identifier. This change checks if i.decl.obj is nil and returns an error
if it is to avoid the crash.

Fixes golang/go#33768

Change-Id: I4e757b42bedffd648fc821590e4a383826200dc3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/191163
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>