| commit | fc82fb2afd64396b05ea9aa0bccd6e8f2257b154 | [log] [tgz] |
|---|---|---|
| author | Suzy Mueller <suzmue@golang.org> | Wed Aug 21 18:13:42 2019 -0400 |
| committer | Suzy Mueller <suzmue@golang.org> | Thu Aug 22 00:03:11 2019 +0000 |
| tree | e7a933f9dcef963501391d1de7df02bbbe42fb96 | |
| parent | 65e3620a7ae7ac25e8494a60f0e5ef4e4fba03b3 [diff] |
internal/lsp: return error when renaming within an import spec Since renaming an identifier within an import spec is not yet supported, return an error when this is encountered. These idents from the import spec have a nil declaration object. Import paths that contain '.' or '/' are caught by the valid identifier check avoiding the crash, but import paths such as "fmt" are not as fmt is a valid identifier. This change checks if i.decl.obj is nil and returns an error if it is to avoid the crash. Fixes golang/go#33768 Change-Id: I4e757b42bedffd648fc821590e4a383826200dc3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/191163 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.